From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] staging: fbtft: fix macro whitespace errors
Date: Fri, 27 Feb 2026 11:42:54 +1000 [thread overview]
Message-ID: <review-overall-aaCIqUXPB75vR6rK@smile.fi.intel.com> (raw)
In-Reply-To: <aaCIqUXPB75vR6rK@smile.fi.intel.com>
Overall Series Review
Subject: Re: [PATCH] staging: fbtft: fix macro whitespace errors
Author: Andy Shevchenko <andriy.shevchenko@intel.com>
Patches: 4
Reviewed: 2026-02-27T11:42:54.570254
---
**NAK — This patch is incorrect and will break compilation.**
This is a single patch that claims to fix "macro whitespace errors" reported by checkpatch.pl in the staging fbtft driver. However, the patch fundamentally misunderstands the code: what appears to be trailing whitespace before the closing parenthesis is actually an **intentionally empty macro argument**. Removing it changes a 4-argument macro invocation into a 3-argument one, which will cause a preprocessor error.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 1:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 17:25 [PATCH] staging: fbtft: fix macro whitespace errors dhyan19022009
2026-02-26 17:53 ` Andy Shevchenko
2026-02-27 1:42 ` Claude Code Review Bot [this message]
2026-02-27 1:42 ` Claude review: " Claude Code Review Bot
2026-02-26 21:36 ` kernel test robot
2026-02-26 23:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-aaCIqUXPB75vR6rK@smile.fi.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox