From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] staging: fbtft: avoid empty macro argument in define_fbtft_write_reg Date: Fri, 13 Mar 2026 14:18:06 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH] staging: fbtft: avoid empty macro argument in define_f= btft_write_reg Author: Dan Carpenter Patches: 2 Reviewed: 2026-03-13T14:18:06.692672 --- This is a single-patch series that replaces empty macro arguments in the `d= efine_fbtft_write_reg` macro invocations with an identity macro `fbtft_iden= tity(x)`. The stated motivation is fixing a checkpatch.pl warning about emp= ty macro arguments. The approach is reasonable and the change is semantical= ly correct =E2=80=94 `fbtft_identity(x)` expands to `(x)`, which is functio= nally equivalent to the empty `modifier` that previously expanded to just t= he bare expression. However, there are a few issues worth noting. --- Generated by Claude Code Patch Reviewer