From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vkms: Constify struct configfs_item_operations and configfs_group_operations Date: Tue, 26 May 2026 07:16:38 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/vkms: Constify struct configfs_item_operations and configfs_group_operations Author: Christophe JAILLET Patches: 1 Reviewed: 2026-05-26T07:16:38.236375 --- This is a single-patch cleanup that adds `const` qualifiers to all `struct configfs_item_operations` and `struct configfs_group_operations` instances in the vkms configfs driver. The change is trivially correct, well-motivated, and a net positive for security and code hygiene. The `config_item_type` structure in `include/linux/configfs.h:67-68` already declares these fields as `const` pointers: ```c const struct configfs_item_operations *ct_item_ops; const struct configfs_group_operations *ct_group_ops; ``` So the framework explicitly expects and supports `const` here. Other subsystems (e.g., USB gadget configfs) already use `const` for these structures. The commit message is clear, includes before/after size data showing the expected text/data shift (~992 bytes moved from writable data to read-only text), and notes it was compile-tested. **Verdict: Patch looks good. No issues found.** --- Generated by Claude Code Patch Reviewer