From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/ivpu: prevent uninitialized data bug in debugfs Date: Tue, 26 May 2026 07:38:50 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: accel/ivpu: prevent uninitialized data bug in debugfs Author: Dan Carpenter Patches: 2 Reviewed: 2026-05-26T07:38:50.251194 --- This is a single-patch fix from Dan Carpenter addressing an uninitialized data bug in the IVPU debugfs `priority_bands_fops_write` handler. The analysis is correct and the fix is appropriate. The core issue: `simple_write_to_buffer()` writes into `buf` starting at offset `*pos` (line 1190 of `fs/libfs.c`: `copy_from_user(to + pos, from, count)`). If `*pos` is non-zero, the bytes in `buf[0..*pos-1]` are left uninitialized on the stack. The subsequent `buf[ret] = '\0'` and `sscanf()` would then operate on partially uninitialized data, which is both a correctness bug and a potential information leak. --- Generated by Claude Code Patch Reviewer