From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH v2] drm/xe/hwmon: document DG2 fan speed reporting quirk Date: Thu, 04 Jun 2026 12:36:36 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH v2] drm/xe/hwmon: document DG2 fan speed reporting quirk Author: Raag Jadav Patches: 6 Reviewed: 2026-06-04T12:36:36.358240 --- This mbox contains three revisions (v2, v3, v4) of a single documentation-only patch for the xe hwmon driver. The patch documents a known DG2 hardware quirk where the second fan channel (`fan2_input`) may read 0 RPM due to shared tach wiring, and explains why this is not a driver bug. The series shows good iterative refinement following reviewer feedback: - **v1** (not in mbox): attempted a code change to reduce the reported fan count on DG2. - **v2**: dropped the code change, added a dedicated `Documentation/gpu/xe/xe_hwmon.rst` doc instead. - **v3**: dropped the standalone doc file; added a short note directly under the `fan2_input` ABI entry per Raag's feedback. - **v4**: identical diff to v3, but adds a `Fixes:` tag and collects `Reviewed-by` from Raag Jadav. **v4 is the latest and should be the one considered for merge.** It is a clean, minimal documentation addition. The patch is correct, well-scoped, and already has a Reviewed-by. **Verdict: v4 looks good to merge.** One minor observation below but nothing blocking. --- --- Generated by Claude Code Patch Reviewer