From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/lease: Limit amount of maximum objects per lease.
Date: Thu, 28 May 2026 12:30:53 +1000 [thread overview]
Message-ID: <review-overall-b3390013-f0de-4e23-a915-23340594fb49@linux.intel.com> (raw)
In-Reply-To: <b3390013-f0de-4e23-a915-23340594fb49@linux.intel.com>
Overall Series Review
Subject: drm/lease: Limit amount of maximum objects per lease.
Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Patches: 1
Reviewed: 2026-05-28T12:30:53.798502
---
This is a single-patch fix for a syzkaller-reported bug where userspace can pass an arbitrarily large `object_count` to the `DRM_IOCTL_MODE_CREATE_LEASE` ioctl, causing `kzalloc_objs()` inside `fill_object_idr()` to attempt an allocation that exceeds `MAX_PAGE_ORDER`, triggering a `WARN_ON` in the page allocator. The fix caps `object_count` to 96 (the sum of the bit widths of the three relevant 32-bit mask types). The approach is sound and correctly placed, but there are a couple of issues that should be addressed before merging.
**Verdict: Needs minor fixes before applying.**
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-28 2:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6a150a33.2b0a0220.185dbd.0005.GAE@google.com>
2026-05-26 19:58 ` [syzbot] [mm?] WARNING in alloc_frozen_pages_noprof (2) Andrew Morton
2026-05-27 9:58 ` [PATCH] drm/lease: Limit amount of maximum objects per lease Maarten Lankhorst
2026-05-28 2:30 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-b3390013-f0de-4e23-a915-23340594fb49@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox