From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] cgroup/dmem: return -ENOMEM on failed pool preallocation Date: Sat, 16 May 2026 15:56:05 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH] cgroup/dmem: return -ENOMEM on failed pool preallocation Author: Tejun Heo Patches: 4 Reviewed: 2026-05-16T15:56:05.178465 --- This is a single-patch fix for a real infinite loop bug in `kernel/cgroup/dmem.c`. The analysis in the commit message is correct: when `get_cg_pool_locked()` returns `ERR_PTR(-ENOMEM)`, the code clears `pool` to NULL, then attempts a fallback `kzalloc_obj()`. If that fallback allocation also fails, `pool` remains NULL and the `while (!pool)` loop spins forever, burning CPU without ever being able to make progress. The fix is minimal, correct, and well-placed. **Verdict: Good patch, should be accepted.** --- Generated by Claude Code Patch Reviewer