From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/hyperv: harden host message parsing Date: Mon, 25 May 2026 17:45:30 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/hyperv: harden host message parsing Author: Berkant Koc Patches: 5 Reviewed: 2026-05-25T17:45:30.405059 --- This is a well-crafted v5 security-hardening series for the Hyper-V synthet= ic video (synthvid) driver. It addresses two real vulnerabilities stemming = from blind trust of host-supplied data: an unbounded `resolution_count` tha= t can walk past a fixed-size array, and a receive callback that processes m= essage payloads without verifying the received byte count covers the fields= being read. Both patches are architecturally sound. Patch 1 is a straightforward bounds= check plus fallback fix. Patch 2 is more involved, restructuring the recei= ve handler into a switch-based dispatch with per-type size validation and a= shared completion path =E2=80=94 the v5 refactor into a single switch is c= leaner than the earlier approach. The variable-length handling for `SYNTHVI= D_RESOLUTION_RESPONSE` is correctly implemented with a two-stage validation= (fixed prefix first, then count-sized array). The `memcpy` change from the= full 16 KiB constant to `bytes_recvd` is a good improvement that eliminate= s stale residue leaking into the waiter's view. The series is suitable for merging. I have a few minor observations but no = blocking issues. --- --- Generated by Claude Code Patch Reviewer