From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: zorro: Improve handling of pointers in zorro_device_id::driver_data Date: Wed, 27 May 2026 14:47:32 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: zorro: Improve handling of pointers in zorro_device_id::driver_data Author: =3D?UTF-8?q?Uwe=3D20Kleine-K=3DC3=3DB6nig=3D20=3D28The=3D20Capable= =3D20Hub=3D29?=3D Patches: 6 Reviewed: 2026-05-27T14:47:32.957704 --- This is a well-structured cleanup series by Uwe Kleine-K=C3=B6nig targeting= the `zorro_device_id` struct to improve type safety when storing pointers = in `driver_data`. The mbox contains only 3 of 8 patches (5, 6, 8) =E2=80=94= those relevant to the video/fbdev and the core header change. The remainin= g patches (1-4, 7) touch ata, scsi, net, and i2c subsystems and were filter= ed out. The core idea (patch 6) is sound: replacing `kernel_ulong_t driver_data` wi= th an anonymous union containing both `driver_data` and `const void *driver= _data_ptr` eliminates unsafe `(unsigned long)` pointer casts. This is a sta= ndard pattern already used in other device ID structs in the kernel (e.g., = `platform_device_id`). The motivation =E2=80=94 CHERI compatibility =E2=80= =94 is legitimate, and the cleanup stands on its own merits regardless. The patches are clean, mechanical, and correct. The anonymous union approac= h preserves backward compatibility with all existing users. No functional c= hanges are introduced. **Recommendation:** The series looks good. No correctness issues found. --- Generated by Claude Code Patch Reviewer