Claude review: Re: [PATCH] drm/amd/amdgpu: remove duplicated code in gfx_v11 and gfx_v12

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Re: [PATCH] drm/amd/amdgpu: remove duplicated code in gfx_v11 and gfx_v12
Author: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Patches: 2
Reviewed: 2026-05-05T10:53:47.373114

---

This is a single-patch cleanup that consolidates identical `handle_priv_fault` implementations from `gfx_v11_0.c` and `gfx_v12_0.c` into a shared `amdgpu_gfx_handle_priv_fault()` in `amdgpu_gfx.c`. The consolidation is correct — I verified that the two original functions are byte-for-byte identical in the current tree. The mechanical transformation is clean.

However, there are a few issues:

1. **`Co-developed-by` tag ordering is wrong** — kernel documentation requires each `Co-developed-by` to be immediately followed by its corresponding `Signed-off-by`, with the submitter's `Signed-off-by` last.
2. **`BUG()` in the default case** — this is inherited from the original code, but consolidating into shared infrastructure is a good opportunity to fix it. `BUG()` in an interrupt handler will panic the kernel. The newer `gfx_v12_1` already uses `dev_dbg()` for this case instead.
3. **Incomplete consolidation** — `gfx_v10_0.c` has a nearly identical implementation (differing only in lacking the `disable_kq` guard), and `gfx_v12_1.c` has a related variant. At minimum, the commit message should acknowledge why these were excluded.
4. **Minor style issues** in the kernel-doc comment.

Verdict: Good idea, needs a v2 to fix the tag ordering and ideally address the `BUG()` concern.

---

---
Generated by Claude Code Patch Reviewer