[PATCH] docs/gpu: fix spelling mistakes in todo.rst

[PATCH] docs/gpu: fix spelling mistakes in todo.rst

[Mikael Rothig]

Fix three spelling mistakes in todo.rst:
- 'varios' -> 'various'
- 'implementions' -> 'implementations'
- 'complection' -> 'completion'

Signed-off-by: Mikael Rothig <mrrothig@gmail.com>
---
v3: Added CC for DRM maintainers and patch description
v2: Squashed 3 patches into one as requested
---
 Documentation/gpu/todo.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 520da44a04a6..686a94bead07 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -269,7 +269,7 @@ Various hold-ups:
   valid formats for atomic drivers.
 
 - Many drivers subclass drm_framebuffer, we'd need a embedding compatible
-  version of the varios drm_gem_fb_create functions. Maybe called
+  version of the various drm_gem_fb_create functions. Maybe called
   drm_gem_fb_create/_with_dirty/_with_funcs as needed.
 
 Contact: Simona Vetter
@@ -294,7 +294,7 @@ everything after it has done the write-protect/mkwrite trickery:
 
       vma->vm_page_prot = pgprot_wrprotect(vma->vm_page_prot);
 
-- Set the mkwrite and fsync callbacks with similar implementions to the core
+- Set the mkwrite and fsync callbacks with similar implementations to the core
   fbdev defio stuff. These should all work on plain ptes, they don't actually
   require a struct page.  uff. These should all work on plain ptes, they don't
   actually require a struct page.
@@ -882,7 +882,7 @@ Querying errors from drm_syncobj
 ================================
 
 The drm_syncobj container can be used by driver independent code to signal
-complection of submission.
+completion of submission.
 
 One minor feature still missing is a generic DRM IOCTL to query the error
 status of binary and timeline drm_syncobj.
-- 
2.49.0

Re: [PATCH] docs/gpu: fix spelling mistakes in todo.rst

[Randy Dunlap]

On 3/6/26 1:56 PM, Mikael Rothig wrote:
> Fix three spelling mistakes in todo.rst:
> - 'varios' -> 'various'
> - 'implementions' -> 'implementations'
> - 'complection' -> 'completion'
> 
> Signed-off-by: Mikael Rothig <mrrothig@gmail.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

In the future, please insert the patch version number into the
email subject line, like
[PATCH v3] docs/gpu: fix spelling mistakes in gpu.rst
The patch version can be (is usually) omitted for v1.

Thanks.

> ---
> v3: Added CC for DRM maintainers and patch description
> v2: Squashed 3 patches into one as requested
> ---
>  Documentation/gpu/todo.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 520da44a04a6..686a94bead07 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -269,7 +269,7 @@ Various hold-ups:
>    valid formats for atomic drivers.
>  
>  - Many drivers subclass drm_framebuffer, we'd need a embedding compatible
> -  version of the varios drm_gem_fb_create functions. Maybe called
> +  version of the various drm_gem_fb_create functions. Maybe called
>    drm_gem_fb_create/_with_dirty/_with_funcs as needed.
>  
>  Contact: Simona Vetter
> @@ -294,7 +294,7 @@ everything after it has done the write-protect/mkwrite trickery:
>  
>        vma->vm_page_prot = pgprot_wrprotect(vma->vm_page_prot);
>  
> -- Set the mkwrite and fsync callbacks with similar implementions to the core
> +- Set the mkwrite and fsync callbacks with similar implementations to the core
>    fbdev defio stuff. These should all work on plain ptes, they don't actually
>    require a struct page.  uff. These should all work on plain ptes, they don't
>    actually require a struct page.
> @@ -882,7 +882,7 @@ Querying errors from drm_syncobj
>  ================================
>  
>  The drm_syncobj container can be used by driver independent code to signal
> -complection of submission.
> +completion of submission.
>  
>  One minor feature still missing is a generic DRM IOCTL to query the error
>  status of binary and timeline drm_syncobj.

-- 
~Randy

Claude review: Re: [PATCH] docs/gpu: fix spelling mistakes in todo.rst

[Claude Code Review Bot]

Overall Series Review

Subject: Re: [PATCH] docs/gpu: fix spelling mistakes in todo.rst
Author: Randy Dunlap <rdunlap@infradead.org>
Patches: 2
Reviewed: 2026-03-09T08:12:28.504725

---

This is a straightforward documentation-only patch that fixes three spelling mistakes in `Documentation/gpu/todo.rst`. All three typos are confirmed present in the current drm-next tree. The fixes are correct and the patch is well-structured. This is now on v3, having been squashed from three separate patches as requested by reviewers, with proper CC list and description added.

The patch did not apply cleanly, likely due to minor context drift on drm-next, but the typos are all still present and the fixes remain valid.

**Verdict: Looks good to apply.**

---
Generated by Claude Code Patch Reviewer

Claude review: Re: [PATCH] docs/gpu: fix spelling mistakes in todo.rst

[Claude Code Review Bot]

Patch Review

**All three fixes are correct:**

1. `varios` → `various` (line 272 of current tree) — confirmed typo still present.
2. `implementions` → `implementations` (line 297) — confirmed typo still present.
3. `complection` → `completion` (line 885) — confirmed typo still present.

**Minor observation (pre-existing, not introduced by this patch):** In the second hunk's context, lines 298–300 of the current tree contain what appears to be a pre-existing copy-paste duplication:

```
- Set the mkwrite and fsync callbacks with similar implementations to the core
  fbdev defio stuff. These should all work on plain ptes, they don't actually
  require a struct page.  uff. These should all work on plain ptes, they don't
  actually require a struct page.
```

The sentence "These should all work on plain ptes, they don't actually require a struct page." is repeated, with a stray "uff." in between. This is not the responsibility of this patch, but the author could optionally fix it as a follow-up or fold it into this patch since they're already touching adjacent lines.

**No issues with the patch itself.**

Reviewed-by assessment: The patch is correct and ready to merge.

---
Generated by Claude Code Patch Reviewer