From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH v2] cgroup/dmem: implement dmem.high soft limit via prioritized eviction
Date: Mon, 25 May 2026 19:12:32 +1000 [thread overview]
Message-ID: <review-overall-f4ce5a78-62a0-4f99-87cf-f5674195f106@gmx.de> (raw)
In-Reply-To: <f4ce5a78-62a0-4f99-87cf-f5674195f106@gmx.de>
Overall Series Review
Subject: Re: [PATCH v2] cgroup/dmem: implement dmem.high soft limit via prioritized eviction
Author: Natalie Vock <natalie.vock@gmx.de>
Patches: 2
Reviewed: 2026-05-25T19:12:32.597474
---
This is a single-patch series (v2) adding a `dmem.high` soft limit to the dmem cgroup v2 controller. When device memory eviction is triggered (e.g., by hitting the hard `max` limit), buffer objects from cgroups exceeding their `high` limit are evicted first via a new prioritized pass in `ttm_bo_evict_alloc()`.
**v2 improves significantly over v1** by replacing sleep-on-allocation throttling (which would be catastrophic for GPU submission) with prioritized eviction. The approach reuses existing `page_counter` infrastructure (`page_counter.high`, `page_counter_set_high()`) and follows the cgroup v2 naming convention (min < low < high < max).
However, there are design concerns around protection bypass, missing documentation/selftests, and a semantic inconsistency with how the memory cgroup controller handles `high` vs protection guarantees.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 8:28 [PATCH v2] cgroup/dmem: implement dmem.high soft limit via prioritized eviction Qiliang Yuan
2026-05-22 9:30 ` Natalie Vock
2026-05-25 9:12 ` Claude Code Review Bot [this message]
2026-05-25 9:12 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-f4ce5a78-62a0-4f99-87cf-f5674195f106@gmx.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox