From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] drm/bridge: waveshare-dsi: Fix signedness bug
Date: Mon, 09 Mar 2026 08:10:07 +1000 [thread overview]
Message-ID: <review-overall-fe3c0b16-1d29-4bca-bff3-15217f9b73f7@mailbox.org> (raw)
In-Reply-To: <fe3c0b16-1d29-4bca-bff3-15217f9b73f7@mailbox.org>
Overall Series Review
Subject: Re: [PATCH] drm/bridge: waveshare-dsi: Fix signedness bug
Author: Marek Vasut <marek.vasut@mailbox.org>
Patches: 4
Reviewed: 2026-03-09T08:10:07.807754
---
This is a single-patch fix for a real signedness bug in the waveshare-dsi bridge driver. The function `drm_of_get_data_lanes_count_ep()` returns a signed `int` (negative on error), but its return value was being stored directly into `dsi->lanes`, which is `unsigned int`. This made the `if (dsi->lanes < 0)` check always false, meaning errors would silently result in a garbage lane count instead of the intended fallback to 2 lanes.
The fix is correct and straightforward. The existing `ret` variable (already declared as `int` at line 50) is reused to capture the return value, the error check is done on `ret`, and the assignment to `dsi->lanes` only happens on the success path.
**Verdict: Good patch, ready to apply.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-08 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 3:32 [PATCH] drm/bridge: waveshare-dsi: Fix signedness bug Ethan Tidmore
2026-03-07 3:44 ` Marek Vasut
2026-03-07 6:42 ` Ethan Tidmore
2026-03-07 15:57 ` Marek Vasut
2026-03-08 22:10 ` Claude Code Review Bot [this message]
2026-03-08 22:10 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-fe3c0b16-1d29-4bca-bff3-15217f9b73f7@mailbox.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox