From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] drm/bridge: waveshare-dsi: Fix signedness bug Date: Mon, 09 Mar 2026 08:10:07 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH] drm/bridge: waveshare-dsi: Fix signedness bug Author: Marek Vasut Patches: 4 Reviewed: 2026-03-09T08:10:07.807754 --- This is a single-patch fix for a real signedness bug in the waveshare-dsi bridge driver. The function `drm_of_get_data_lanes_count_ep()` returns a signed `int` (negative on error), but its return value was being stored directly into `dsi->lanes`, which is `unsigned int`. This made the `if (dsi->lanes < 0)` check always false, meaning errors would silently result in a garbage lane count instead of the intended fallback to 2 lanes. The fix is correct and straightforward. The existing `ret` variable (already declared as `int` at line 50) is reused to capture the return value, the error check is done on `ret`, and the assignment to `dsi->lanes` only happens on the success path. **Verdict: Good patch, ready to apply.** --- Generated by Claude Code Patch Reviewer