From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: Replace old pointer to new idr Date: Sat, 16 May 2026 12:36:42 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: Replace old pointer to new idr Author: Edward Adam Davis Patches: 1 Reviewed: 2026-05-16T12:36:42.355520 --- This is a single-patch fix for a syzbot-reported bug where `drm_prime_destr= oy_file_private` triggers `WARN_ON(!RB_EMPTY_ROOT(&prime_fpriv->dmabufs))` = on file close. The patch correctly identifies that commit 5e28b7b94408 plac= ed the `idr_replace` call in the error path instead of the success path, bu= t the fix itself introduces a **new, more serious bug** by removing the nec= essary `idr_alloc` failure check. The drm-next tree already has a clean ver= sion of this function without `idr_replace`, suggesting this fix may alread= y be superseded or targeting a different branch. **Verdict: NACK in current form** =E2=80=94 the core idea (moving `idr_repl= ace` to the success path) is right, but the removal of the `ret < 0` check = after `idr_alloc` is incorrect and introduces state corruption. --- --- Generated by Claude Code Patch Reviewer