From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: None Date: Thu, 12 Feb 2026 17:08:27 +1000 Message-ID: In-Reply-To: References: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Overall Series Review Subject: None Author: None Patches: 0 Reviewed: 2026-02-12T17:08:27.857739 --- This 8-patch series adds support for batch allocation of multiple non-contiguous userptr ranges through the AMD KFD (Kernel Fusion Driver) interface. The implementation uses a single MMU notifier spanning the entire VA range with an interval tree to efficiently track which specific ranges are invalidated. **Architecture Overview:** The series extends the existing userptr allocation mechanism to handle multiple CPU VA ranges that map to a single contiguous GPU VA. The key design choice is using one `mmu_interval_notifier` covering [va_min, va_max] with an interval tree to filter invalidation events. **Major Concerns:** 1. **UAPI Stability** - Patch 1 adds new UAPI structures without incrementing KFD_IOCTL_MINOR_VERSION 2. **Memory Safety** - Several error paths lack proper cleanup 3. **Locking Issues** - Complex interaction between multiple locks with potential for deadlocks 4. **Resource Leaks** - Interval tree nodes not always removed on error paths 5. **Data Structure Initialization** - Missing initialization of critical fields in error scenarios **Series Strengths:** - Well-structured patch split for review - Handles complex MMU notifier scenarios - Interval tree usage is appropriate for the problem --- --- Generated by Claude Code Patch Reviewer