From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: Introduce DMA-buf mapping types Date: Wed, 18 Feb 2026 11:37:56 +1000 Message-ID: In-Reply-To: <1-v1-b5cab63049c0+191af-dmabuf_map_type_jgg@nvidia.com> References: <0-v1-b5cab63049c0+191af-dmabuf_map_type_jgg@nvidia.com> <1-v1-b5cab63049c0+191af-dmabuf_map_type_jgg@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds the core framework types and `dma_buf_match_mapping()`. > +/* Type tag for all mapping operations */ > +struct dma_buf_mapping_exp_ops {}; This appears both as a forward declaration (`struct dma_buf_mapping_exp_ops;`) and then as a definition. Minor -- could be consolidated. > + if (exp->type->match) { > + ret = exp->type->match(args->dmabuf, exp, imp); > + if (ret == -EOPNOTSUPP) > + continue; > + if (ret != 0) > + return ret; > + } > + exp->type->finish_match(args, exp, imp); `finish_match` is called unconditionally but isn't checked for NULL. This is fine as long as every `dma_buf_mapping_type` provides it, but it might be worth documenting as a mandatory callback in the kerneldoc for the struct. No bugs found. --- Generated by Claude Code Patch Reviewer