From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] accel/amdxdna: fix missing newline in pr_err message Date: Sun, 22 Mar 2026 03:46:13 +1000 Message-ID: In-Reply-To: <1af543d3-46ff-7a9c-6432-fe3c9050e23d@amd.com> References: <1af543d3-46ff-7a9c-6432-fe3c9050e23d@amd.com> <1af543d3-46ff-7a9c-6432-fe3c9050e23d@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Correct, minor nits only.** The change itself is straightforward and correct: ```c - pr_err("Ring buf size must be power of 2"); + pr_err("Ring buf size must be power of 2\n"); ``` I confirmed the current drm-next tree still has the missing newline at `drivers/accel/amdxdna/amdxdna_mailbox.c:502`, so this fix is still needed. **Nits:** 1. **Signed-off-by name**: The `Signed-off-by: haoyu.lu ` should use the author's real name, e.g., `Signed-off-by: Haoyu Lu `, consistent with the `From:` header and kernel conventions (see `Documentation/process/submitting-patches.rst`). 2. **Consider dev_err()**: This `pr_err()` could potentially be converted to `dev_err()` to include device context in the log message, making it easier to identify which device triggered the error in multi-device systems. However, that would be a separate cleanup patch and is outside the scope of this fix. 3. **Commit message**: The commit message is adequate but could mention the specific consequence (log line concatenation with subsequent messages) to explain *why* the newline matters. --- Generated by Claude Code Patch Reviewer