From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/guc: fix corrupted copyright symbols in selftest
 files
Date: Wed, 11 Feb 2026 17:00:05 +1000
Message-ID: <review-patch1-20260209112709.2551603-1-khorenko@virtuozzo.com>
In-Reply-To: <20260209112709.2551603-1-khorenko@virtuozzo.com>
References: <20260209112709.2551603-1-khorenko@virtuozzo.com> <20260209112709.2551603-1-khorenko@virtuozzo.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Mailer: Claude Code Patch Reviewer

Patch Review

**Summary**: Replaces corrupted UTF-8 sequences with proper © symbols in copyright headers of two GuC selftest files.

**Commit Message Analysis**:
- Subject line is clear and follows kernel conventions (subsystem prefix: drm/i915/guc)
- Body adequately describes what is changed
- Missing: How this corruption occurred, whether it's widespread

**Technical Review**:

```
diff --git a/drivers/gpu/drm/i915/gt/uc/selftest_guc.c b/drivers/gpu/drm/i915/gt/uc/selftest_guc.c
index 68feb55654f77..0ef294bef00b9 100644
--- a/drivers/gpu/drm/i915/gt/uc/selftest_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/selftest_guc.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: MIT
 /*
- * Copyright �� 2021 Intel Corporation
+ * Copyright © 2021 Intel Corporation
  */
```

**Analysis**:
- Change is purely cosmetic in a comment block
- Maintains proper SPDX license identifier (untouched)
- File encoding issue correction - no functional impact
- The replacement character sequence suggests double corruption or encoding detection failure

```
diff --git a/drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c b/drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c
index a40e7c32e6137..28e8a092f4e7d 100644
--- a/drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c
+++ b/drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: MIT
 /*
- * Copyright �� 2019 Intel Corporation
+ * Copyright © 2019 Intel Corporation
  */
```

**Analysis**:
- Identical fix pattern to first file
- Different copyright year (2019 vs 2021) - both appear legitimate based on file history

**Issues Found**: None - patch is correct as-is

**Questions for Maintainer**:
1. Should we audit the entire i915 driver tree for similar corruption?
2. Is there a preference for "©" vs "(C)" in i915 copyright headers?
3. Do the build/CI systems validate UTF-8 encoding in source files?

**Tested-by / Reviewed-by**: None present - this is expected for initial submission

**Recommendation**: 

**Acked-by** - This patch is appropriate and correctly fixes the stated issue.

**Suggestions**:
- Consider running: `git grep -P '[^\x00-\x7F].*Copyright.*Intel' drivers/gpu/drm/i915/` to find other potential encoding issues
- If widespread, might justify a larger cleanup series
- For v2 (if needed): Add note about whether this was checked tree-wide

---
Generated by Claude Code Patch Reviewer