[PATCH] drm/i915/guc: fix corrupted copyright symbols in selftest files

[PATCH] drm/i915/guc: fix corrupted copyright symbols in selftest files

[Konstantin Khorenko]

Replace broken UTF-8 sequences (Unicode replacement characters) with
proper "©" text in copyright headers.

Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
 drivers/gpu/drm/i915/gt/uc/selftest_guc.c           | 2 +-
 drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/selftest_guc.c b/drivers/gpu/drm/i915/gt/uc/selftest_guc.c
index 68feb55654f77..0ef294bef00b9 100644
--- a/drivers/gpu/drm/i915/gt/uc/selftest_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/selftest_guc.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: MIT
 /*
- * Copyright �� 2021 Intel Corporation
+ * Copyright © 2021 Intel Corporation
  */
 
 #include "gt/intel_gt_print.h"
diff --git a/drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c b/drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c
index a40e7c32e6137..28e8a092f4e7d 100644
--- a/drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c
+++ b/drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: MIT
 /*
- * Copyright �� 2019 Intel Corporation
+ * Copyright © 2019 Intel Corporation
  */
 
 #include "gt/intel_gt_print.h"
-- 
2.43.0

Claude review: drm/i915/guc: fix corrupted copyright symbols in selftest files

[Claude Code Review Bot]

Overall Series Review

Subject: drm/i915/guc: fix corrupted copyright symbols in selftest
 files
Author: Konstantin Khorenko <khorenko@virtuozzo.com>
Patches: 1
Reviewed: 2026-02-11T17:00:04.900261

---

This is a single-patch series that addresses a cosmetic issue in copyright headers. The patch fixes corrupted UTF-8 copyright symbols (©) that were rendered as Unicode replacement characters in two i915 GuC selftest files.

**Scope**: Documentation/cosmetic fix only - no functional changes
**Risk Level**: Minimal - only modifies copyright header comments
**Testing Required**: None (comment-only changes)

The patch is straightforward and appropriate. However, there are some considerations:

1. **Completeness**: The patch only fixes 2 files. A broader audit may be warranted to check if other files in the i915 driver (or kernel-wide) have the same corruption.

2. **Root Cause**: The commit message doesn't explain how these became corrupted or whether this is a systematic issue that could recur.

3. **Alternative Approach**: Some kernel subsystems prefer ASCII-only copyright headers using "(C)" instead of "©" to avoid encoding issues entirely. This might be worth discussing with maintainers.

**Recommendation**: The patch itself is fine and can be merged, but consider:
- Checking for similar issues in other i915 files
- Documenting whether UTF-8 copyright symbols are preferred over ASCII equivalents in i915

---
Generated by Claude Code Patch Reviewer

Claude review: drm/i915/guc: fix corrupted copyright symbols in selftest files

[Claude Code Review Bot]

Patch Review

**Summary**: Replaces corrupted UTF-8 sequences with proper © symbols in copyright headers of two GuC selftest files.

**Commit Message Analysis**:
- Subject line is clear and follows kernel conventions (subsystem prefix: drm/i915/guc)
- Body adequately describes what is changed
- Missing: How this corruption occurred, whether it's widespread

**Technical Review**:

```
diff --git a/drivers/gpu/drm/i915/gt/uc/selftest_guc.c b/drivers/gpu/drm/i915/gt/uc/selftest_guc.c
index 68feb55654f77..0ef294bef00b9 100644
--- a/drivers/gpu/drm/i915/gt/uc/selftest_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/selftest_guc.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: MIT
 /*
- * Copyright �� 2021 Intel Corporation
+ * Copyright © 2021 Intel Corporation
  */
```

**Analysis**:
- Change is purely cosmetic in a comment block
- Maintains proper SPDX license identifier (untouched)
- File encoding issue correction - no functional impact
- The replacement character sequence suggests double corruption or encoding detection failure

```
diff --git a/drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c b/drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c
index a40e7c32e6137..28e8a092f4e7d 100644
--- a/drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c
+++ b/drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: MIT
 /*
- * Copyright �� 2019 Intel Corporation
+ * Copyright © 2019 Intel Corporation
  */
```

**Analysis**:
- Identical fix pattern to first file
- Different copyright year (2019 vs 2021) - both appear legitimate based on file history

**Issues Found**: None - patch is correct as-is

**Questions for Maintainer**:
1. Should we audit the entire i915 driver tree for similar corruption?
2. Is there a preference for "©" vs "(C)" in i915 copyright headers?
3. Do the build/CI systems validate UTF-8 encoding in source files?

**Tested-by / Reviewed-by**: None present - this is expected for initial submission

**Recommendation**: 

**Acked-by** - This patch is appropriate and correctly fixes the stated issue.

**Suggestions**:
- Consider running: `git grep -P '[^\x00-\x7F].*Copyright.*Intel' drivers/gpu/drm/i915/` to find other potential encoding issues
- If widespread, might justify a larger cleanup series
- For v2 (if needed): Add note about whether this was checked tree-wide

---
Generated by Claude Code Patch Reviewer