From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/gem-shmem: Use obj directly where appropriate in fault handler
Date: Wed, 11 Feb 2026 17:04:33 +1000 [thread overview]
Message-ID: <review-patch1-20260209133241.238813-2-tzimmermann@suse.de> (raw)
In-Reply-To: <20260209133241.238813-2-tzimmermann@suse.de>
Patch Review
**Review:**
Simple readability improvement. The change is sound and straightforward.
```c
- dma_resv_lock(shmem->base.resv, NULL);
+ dma_resv_lock(obj->resv, NULL);
```
This is cleaner since `obj` is already defined as `vma->vm_private_data` and `obj == &shmem->base`.
**Issues:** None
**Verdict:** ✓ Good cleanup patch
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-11 7:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 13:27 [PATCH v3 0/6] drm/gem-shmem: Track page accessed/dirty status Thomas Zimmermann
2026-02-09 13:27 ` [PATCH v3 1/6] drm/gem-shmem: Use obj directly where appropriate in fault handler Thomas Zimmermann
2026-02-09 14:10 ` Boris Brezillon
2026-02-11 7:04 ` Claude Code Review Bot [this message]
2026-02-09 13:27 ` [PATCH v3 2/6] drm/gem-shmem: Test for existence of page in mmap " Thomas Zimmermann
2026-02-09 14:10 ` Boris Brezillon
2026-02-11 7:04 ` Claude review: " Claude Code Review Bot
2026-02-09 13:27 ` [PATCH v3 3/6] drm/gem-shmem: Return vm_fault_t from drm_gem_shmem_try_map_pmd() Thomas Zimmermann
2026-02-11 7:04 ` Claude review: " Claude Code Review Bot
2026-02-09 13:27 ` [PATCH v3 4/6] drm/gem-shmem: Refactor drm_gem_shmem_try_map_pmd() Thomas Zimmermann
2026-02-09 14:25 ` Boris Brezillon
2026-02-11 7:04 ` Claude review: " Claude Code Review Bot
2026-02-09 13:27 ` [PATCH v3 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap Thomas Zimmermann
2026-02-09 14:23 ` Boris Brezillon
2026-02-09 14:46 ` Thomas Zimmermann
2026-02-09 15:01 ` Boris Brezillon
2026-02-11 7:04 ` Claude review: " Claude Code Review Bot
2026-02-09 13:27 ` [PATCH v3 6/6] drm/gem-shmem: Track folio accessed/dirty status in vmap Thomas Zimmermann
2026-02-11 7:04 ` Claude review: " Claude Code Review Bot
2026-02-11 7:04 ` Claude review: drm/gem-shmem: Track page accessed/dirty status Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260209133241.238813-2-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox