public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: arm: qcom: document google, bonito-tianma board
Date: Wed, 11 Feb 2026 16:47:57 +1000	[thread overview]
Message-ID: <review-patch1-20260210023300.15785-2-mailingradian@gmail.com> (raw)
In-Reply-To: <20260210023300.15785-2-mailingradian@gmail.com>

Patch Review

**Commit Message Issues (CRITICAL):**

```
The google,bonito-sdc board compatible represents the Google Pixel 3a XL
with a Tianma/Novatek NT37700F panel. Document it in the bindings.
```

The message refers to "bonito-sdc" but the actual compatible added is "bonito-tianma". This appears to be a copy-paste error from downstream sources.

**Technical Review:**

```yaml
+      - items:
+          - enum:
+              - google,bonito-tianma
+          - const: google,bonito
+          - const: qcom,sdm670
```

**ISSUE:** This creates a compatibility hierarchy `bonito-tianma -> bonito -> sdm670`, but the base "google,bonito" compatible is not documented anywhere in this series. As Krzysztof Kozlowski noted in review, this needs clarification about what "bonito" represents and why it's compatible with sdm670.

**Required Changes:**
1. Fix commit message to say "bonito-tianma" not "bonito-sdc"
2. Either add base "google,bonito" compatible in a separate patch, or flatten to just two levels if no base device exists

**Rating:** NEEDS REVISION

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-02-11  6:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  2:32 [PATCH 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-10  2:32 ` [PATCH 1/6] dt-bindings: arm: qcom: document google, bonito-tianma board Richard Acayan
2026-02-10  9:12   ` Krzysztof Kozlowski
2026-02-11  6:47   ` Claude Code Review Bot [this message]
2026-02-10  2:32 ` [PATCH 2/6] dt-bindings: panel-simple-dsi: add nt37700f compatible Richard Acayan
2026-02-10  9:12   ` Krzysztof Kozlowski
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 ` [PATCH 3/6] drm/panel: Add Novatek/Tianma NT37700F panel Richard Acayan
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 ` [PATCH 4/6] arm64: dts: qcom: sdm670-google-sargo: add touchscreen and display labels Richard Acayan
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 ` [PATCH 5/6] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-12 10:30   ` [PATCH 5/6] " Konrad Dybcio
2026-02-10  2:33 ` [PATCH 6/6] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-02-10  9:10   ` Konrad Dybcio
2026-02-11 19:33     ` Richard Acayan
2026-02-12 10:29       ` Konrad Dybcio
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-11  6:47 ` Claude review: Support for the Pixel 3a XL with the Tianma panel Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260210023300.15785-2-mailingradian@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox