From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: arm: qcom: document google, bonito-tianma board Date: Wed, 11 Feb 2026 16:47:57 +1000 Message-ID: In-Reply-To: <20260210023300.15785-2-mailingradian@gmail.com> References: <20260210023300.15785-1-mailingradian@gmail.com> <20260210023300.15785-2-mailingradian@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Patch Review **Commit Message Issues (CRITICAL):** ``` The google,bonito-sdc board compatible represents the Google Pixel 3a XL with a Tianma/Novatek NT37700F panel. Document it in the bindings. ``` The message refers to "bonito-sdc" but the actual compatible added is "bonito-tianma". This appears to be a copy-paste error from downstream sources. **Technical Review:** ```yaml + - items: + - enum: + - google,bonito-tianma + - const: google,bonito + - const: qcom,sdm670 ``` **ISSUE:** This creates a compatibility hierarchy `bonito-tianma -> bonito -> sdm670`, but the base "google,bonito" compatible is not documented anywhere in this series. As Krzysztof Kozlowski noted in review, this needs clarification about what "bonito" represents and why it's compatible with sdm670. **Required Changes:** 1. Fix commit message to say "bonito-tianma" not "bonito-sdc" 2. Either add base "google,bonito" compatible in a separate patch, or flatten to just two levels if no base device exists **Rating:** NEEDS REVISION --- --- Generated by Claude Code Patch Reviewer