From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: clk: bcm: rpi: Let V3D consumers manage clock rate Date: Sat, 14 Feb 2026 07:21:52 +1000 Message-ID: In-Reply-To: <20260213-v3d-power-management-v5-1-7a8b381eb379@igalia.com> References: <20260213-v3d-power-management-v5-0-7a8b381eb379@igalia.com> <20260213-v3d-power-management-v5-1-7a8b381eb379@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This removes the `maximize` infrastructure and stops forcing the V3D clock to= maximum rate, giving consumers (the V3D driver) direct control over clock ra= te. > - bool maximize; > - [RPI_FIRMWARE_V3D_CLK_ID] =3D { > - .export =3D true, > - .maximize =3D true, > - }, > - if (variant->maximize) > - variant->min_rate =3D max_rate; The `maximize` field is only used for the V3D clock, so removing it along wit= h the single usage site is clean. The `minimize` field is also not set for V3= D, giving full consumer control. The Fixes tag referencing the commit that ad= ded `maximize` is appropriate since that commit prevented consumers from mana= ging clock rates for power savings. No issues found. --- Generated by Claude Code Patch Reviewer