public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: Fix uninitialized buddy for built-in drivers
Date: Mon, 23 Feb 2026 06:25:10 +1000	[thread overview]
Message-ID: <review-patch1-20260213152047.179628-1-koen.koning@linux.intel.com> (raw)
In-Reply-To: <20260213152047.179628-1-koen.koning@linux.intel.com>

Patch Review

> -module_init(gpu_buddy_module_init);
> +subsys_initcall(gpu_buddy_module_init);

This is the patch that fixes the actual regression. The buddy allocator must initialize before drivers that use it, and after the recent move from `drm/` to `gpu/`, the link order placed it after the DRM drivers. Using `subsys_initcall()` guarantees it runs before any `device_initcall()` (i.e., `module_init()` built-in) code.

Functionally correct. The `module_exit()` left as-is on the next line is fine -- `module_exit()` for built-in code is typically a no-op or runs at the corresponding exit stage.

The commit message now includes both Fixes tags as Danilo requested. The Fixes tag pointing to `ba110db8e1bc` ("gpu: Move DRM buddy allocator one level up (part two)") is debatable -- that commit exposed the latent bug by changing link order, but the underlying issue (using `module_init()` for infrastructure code) existed since the buddy allocator was moved out of i915. Including both tags is reasonable since `ba110db8e1bc` is what caused the actual regression.

Given Greg KH's feedback, the simpler v1 Makefile ordering fix may be the preferred approach for this patch. The Makefile ordering fix is a smaller change, more targeted, and follows the existing pattern used by `host1x`/`tegra` in the same Makefile.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-02-22 20:25 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 15:20 [PATCH] gpu: Fix uninitialized buddy for built-in drivers Koen Koning
2026-02-13 17:27 ` Joel Fernandes
2026-02-16 10:28   ` Matthew Auld
2026-02-22 20:25     ` Claude review: " Claude Code Review Bot
2026-02-22 20:25   ` Claude Code Review Bot
2026-02-16 11:19 ` [PATCH v2] " Koen Koning
2026-02-16 21:31   ` Joel Fernandes
2026-02-19 10:16   ` Danilo Krummrich
2026-02-19 10:38     ` Matthew Auld
2026-02-19 11:14       ` Danilo Krummrich
2026-02-19 12:44         ` Matthew Auld
2026-02-19 12:56           ` Danilo Krummrich
2026-02-19 15:32             ` Matthew Auld
2026-02-19 16:08               ` Danilo Krummrich
2026-02-19 18:28             ` Koen Koning
2026-02-19 18:34               ` Danilo Krummrich
2026-02-19 21:38   ` [PATCH v3 0/3] gpu: fix module_init() usage Koen Koning
2026-02-19 21:38     ` [PATCH v3 1/3] gpu/buddy: " Koen Koning
2026-02-20  6:06       ` Greg KH
2026-02-20 10:17         ` Danilo Krummrich
2026-02-20 13:55           ` Joel Fernandes
2026-02-21  5:44             ` Greg KH
2026-02-19 21:38     ` [PATCH v3 2/3] drm/sched: " Koen Koning
2026-02-20  6:06       ` Greg KH
2026-02-19 21:38     ` [PATCH v3 3/3] drm/drv: " Koen Koning
2026-02-22 20:25     ` Claude review: gpu: " Claude Code Review Bot
2026-02-22 20:25 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260213152047.179628-1-koen.koning@linux.intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox