From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: media: videobuf2: Set vma_flags in vb2_dma_sg_mmap
Date: Mon, 16 Feb 2026 06:42:02 +1000 [thread overview]
Message-ID: <review-patch1-20260215-media-vb2-dma-sg-v1-1-91b6aa6c1cec@jannau.net> (raw)
In-Reply-To: <20260215-media-vb2-dma-sg-v1-1-91b6aa6c1cec@jannau.net>
Patch Review
> + vm_flags_set(vma, VM_DONTEXPAND | VM_DONTDUMP);
> /*
> * Use common vm_area operations to track buffer refcount.
> */
No issues. The placement is correct — after `vm_map_pages()` succeeds and before setting up `vm_ops` / `vm_private_data`, exactly mirroring the pattern in `vb2_dma_contig_mmap()` at `videobuf2-dma-contig.c:296`. The `vm_flags_set()` API is the correct accessor (rather than directly manipulating `vma->vm_flags`).
The `Fixes:` tag pointing to the original commit that introduced `vb2_dma_sg` (`5ba3f757f059`) is reasonable. While the WARN_ON in `drm_gem_mmap_obj()` was added later, the omission of these flags has been present since the allocator's introduction, and the flags are independently correct for this type of buffer (preventing userspace from expanding or dumping GPU-backed mappings).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-15 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 17:42 [PATCH] media: videobuf2: Set vma_flags in vb2_dma_sg_mmap Janne Grunau
2026-02-15 20:42 ` Claude Code Review Bot [this message]
2026-02-15 20:42 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260215-media-vb2-dma-sg-v1-1-91b6aa6c1cec@jannau.net \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox