public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: misc: fastrpc: Move fdlist to invoke context structure
Date: Mon, 16 Feb 2026 08:26:14 +1000	[thread overview]
Message-ID: <review-patch1-20260215182136.3995111-2-ekansh.gupta@oss.qualcomm.com> (raw)
In-Reply-To: <20260215182136.3995111-2-ekansh.gupta@oss.qualcomm.com>

Patch Review

**Assessment: Acceptable with minor comments**

This is a clean refactoring patch. Moving `fdlist` into `fastrpc_invoke_ctx` eliminates the redundant pointer computation in `fastrpc_put_args`.

One concern: In the original `fastrpc_put_args`, the fdlist pointer was computed using the actual scalar breakdown:

```c
fdlist = (uint64_t *)(pages + inbufs + outbufs + handles);
```

In `fastrpc_get_args`, it's now computed as:

```c
ctx->fdlist = (u64 *)(pages + ctx->nscalars);
```

Since `nscalars = inbufs + outbufs + REMOTE_SCALARS_INHANDLES(sc) + REMOTE_SCALARS_OUTHANDLES(sc)`, which equals `inbufs + outbufs + handles`, these are equivalent. This is correct.

The removal of the now-unused `outbufs`, `handles`, `list`, `pages` local variables from `fastrpc_put_args` is appropriate.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-15 22:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-15 18:21 [PATCH v6 0/4] misc: fastrpc: Add polling mode support Ekansh Gupta
2026-02-15 18:21 ` [PATCH v6 1/4] misc: fastrpc: Move fdlist to invoke context structure Ekansh Gupta
2026-02-15 22:26   ` Claude Code Review Bot [this message]
2026-02-15 18:21 ` [PATCH v6 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Ekansh Gupta
2026-02-15 22:26   ` Claude review: " Claude Code Review Bot
2026-02-15 18:21 ` [PATCH v6 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Ekansh Gupta
2026-02-15 22:26   ` Claude review: " Claude Code Review Bot
2026-02-15 18:21 ` [PATCH v6 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Ekansh Gupta
2026-02-15 22:26   ` Claude review: " Claude Code Review Bot
2026-02-15 20:40 ` Claude review: misc: fastrpc: Add polling mode support Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260215182136.3995111-2-ekansh.gupta@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox