From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Move fdlist to invoke context structure Date: Mon, 16 Feb 2026 08:26:14 +1000 Message-ID: In-Reply-To: <20260215182136.3995111-2-ekansh.gupta@oss.qualcomm.com> References: <20260215182136.3995111-1-ekansh.gupta@oss.qualcomm.com> <20260215182136.3995111-2-ekansh.gupta@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Assessment: Acceptable with minor comments** This is a clean refactoring patch. Moving `fdlist` into `fastrpc_invoke_ctx` = eliminates the redundant pointer computation in `fastrpc_put_args`. One concern: In the original `fastrpc_put_args`, the fdlist pointer was compu= ted using the actual scalar breakdown: ```c fdlist =3D (uint64_t *)(pages + inbufs + outbufs + handles); ``` In `fastrpc_get_args`, it's now computed as: ```c ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); ``` Since `nscalars =3D inbufs + outbufs + REMOTE_SCALARS_INHANDLES(sc) + REMOTE_= SCALARS_OUTHANDLES(sc)`, which equals `inbufs + outbufs + handles`, these are= equivalent. This is correct. The removal of the now-unused `outbufs`, `handles`, `list`, `pages` local var= iables from `fastrpc_put_args` is appropriate. --- Generated by Claude Code Patch Reviewer