From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: ARM: dts: twl6032: Add DTS file for TWL6032 PMIC Date: Mon, 23 Feb 2026 06:16:27 +1000 Message-ID: In-Reply-To: <20260219210408.5451-2-bavishimithil@gmail.com> References: <20260219210408.5451-1-bavishimithil@gmail.com> <20260219210408.5451-2-bavishimithil@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This adds a new dtsi for the TWL6032 PMIC, modeled after the existing twl6030.dtsi. The structure and compatible strings look correct. The TWL6032 has a different regulator set (ldo1-ldo6, vio, ldoln, ldousb, smps4) compared to the TWL6030 (vaux1-3, vmmc, vpp, vusim, etc.), and the `gpadc` node correctly uses the `ti,twl6032-gpadc` compatible. The shared peripherals (usb-comparator, pwm, pwmled) reuse the `ti,twl6030-*` compatibles, which is appropriate since the driver handles both. One difference from twl6030.dtsi: this file adds a `gpadc:` label on the gpadc node, which is needed because the espresso common dtsi references `&gpadc` for the current-sense-shunt io-channel. The twl6030.dtsi does not have this label. This is fine and intentional. No issues found. --- Generated by Claude Code Patch Reviewer