From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: ipu-v3: clean up kernel-doc warnings Date: Mon, 23 Feb 2026 06:22:16 +1000 Message-ID: In-Reply-To: <20260219215211.459108-1-rdunlap@infradead.org> References: <20260219215211.459108-1-rdunlap@infradead.org> <20260219215211.459108-1-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review No functional issues. All changes are kernel-doc comment fixes that address the specific warnings listed in the commit message. > + /* private: */ > /* internal to image converter, callers don't touch */ > struct list_head list; Correct use of the `/* private: */` kernel-doc annotation to suppress the warning about undocumented `list` member. > - * ipu_image_convert_cb_t - conversion callback function prototype > + * typedef ipu_image_convert_cb_t - conversion callback function prototype Correct fix. Kernel-doc requires `typedef` for typedef documentation. > - * Returns 0 if the formats and rotation mode meet IPU restrictions, > + * Returns: 0 if the formats and rotation mode meet IPU restrictions, Correct. Kernel-doc expects `Returns:` with a colon. > - * Returns an opaque conversion context pointer on success, error pointer > + * In V4L2, drivers should call ipu_image_convert_prepare() at streamon. > + * > + * Returns: an opaque conversion context pointer on success, error pointer > * on failure. The input/output formats and rotation mode must already meet > * IPU retrictions. > - * > - * In V4L2, drivers should call ipu_image_convert_prepare() at streamon. This moves the `In V4L2` note before `Returns:` so the return value documentation appears last. This is the correct kernel-doc convention -- `Returns:` should be the final section. One minor note: the pre-existing typo "retrictions" (should be "restrictions") survives this patch, but fixing it is outside the scope of a doc-format cleanup. > + * Returns: 0 on success or -errno on error. > + * Returns: pointer to the created &struct ipu_image_convert_run that has > + * been queued on success; an ERR_PTR(errno) on error. Both additions are accurate descriptions matching the function signatures and existing documentation prose. No issues found. The patch is a clean documentation fix that addresses all seven kernel-doc warnings listed in the commit message. --- Generated by Claude Code Patch Reviewer