* [PATCH v2] drm/gpusvm: correct kernel-doc for drm_gpusvm_pages_valid_unlocked()
@ 2026-02-19 21:55 Randy Dunlap
2026-02-22 20:21 ` Claude review: " Claude Code Review Bot
2026-02-22 20:21 ` Claude Code Review Bot
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2026-02-19 21:55 UTC (permalink / raw)
To: dri-devel
Cc: Randy Dunlap, David Airlie, Simona Vetter, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann
Use the correct function name and parameter description to avoid these
warnings:
WARNING: drivers/gpu/drm/drm_gpusvm.c:1351 function parameter 'svm_pages'
not described in 'drm_gpusvm_pages_valid_unlocked'
WARNING: drivers/gpu/drm/drm_gpusvm.c:1351 expecting prototype for
drm_gpusvm_range_pages_valid_unlocked(). Prototype was for
drm_gpusvm_pages_valid_unlocked() instead
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
v2: rebase & resend
Cc: David Airlie <airlied@gmail.com>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/drm_gpusvm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20260218.orig/drivers/gpu/drm/drm_gpusvm.c
+++ linux-next-20260218/drivers/gpu/drm/drm_gpusvm.c
@@ -1338,9 +1338,9 @@ bool drm_gpusvm_range_pages_valid(struct
EXPORT_SYMBOL_GPL(drm_gpusvm_range_pages_valid);
/**
- * drm_gpusvm_range_pages_valid_unlocked() - GPU SVM range pages valid unlocked
+ * drm_gpusvm_pages_valid_unlocked() - GPU SVM range pages valid unlocked
* @gpusvm: Pointer to the GPU SVM structure
- * @range: Pointer to the GPU SVM range structure
+ * @svm_pages: Pointer to the GPU SVM pages structure
*
* This function determines if a GPU SVM range pages are valid. Expected be
* called without holding gpusvm->notifier_lock.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Claude review: drm/gpusvm: correct kernel-doc for drm_gpusvm_pages_valid_unlocked()
2026-02-19 21:55 [PATCH v2] drm/gpusvm: correct kernel-doc for drm_gpusvm_pages_valid_unlocked() Randy Dunlap
@ 2026-02-22 20:21 ` Claude Code Review Bot
2026-02-22 20:21 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-02-22 20:21 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: drm/gpusvm: correct kernel-doc for drm_gpusvm_pages_valid_unlocked()
Author: Randy Dunlap <rdunlap@infradead.org>
Patches: 1
Reviewed: 2026-02-23T06:21:10.333996
---
This is a single-patch series that fixes kernel-doc warnings for the `drm_gpusvm_pages_valid_unlocked()` function in `drivers/gpu/drm/drm_gpusvm.c`. The function was apparently renamed from `drm_gpusvm_range_pages_valid_unlocked()` at some point (likely when refactoring to use `struct drm_gpusvm_pages` instead of `struct drm_gpusvm_range`), but the kernel-doc comment block was not updated to reflect the new function name and parameter. This patch corrects both the function name and the parameter description in the doc comment.
The fix is trivially correct and resolves two concrete `kernel-doc` warnings cited in the commit message.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Claude review: drm/gpusvm: correct kernel-doc for drm_gpusvm_pages_valid_unlocked()
2026-02-19 21:55 [PATCH v2] drm/gpusvm: correct kernel-doc for drm_gpusvm_pages_valid_unlocked() Randy Dunlap
2026-02-22 20:21 ` Claude review: " Claude Code Review Bot
@ 2026-02-22 20:21 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-02-22 20:21 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
> - * drm_gpusvm_range_pages_valid_unlocked() - GPU SVM range pages valid unlocked
> + * drm_gpusvm_pages_valid_unlocked() - GPU SVM range pages valid unlocked
Correct. The actual function prototype is `drm_gpusvm_pages_valid_unlocked()`, so the doc comment now matches.
> - * @range: Pointer to the GPU SVM range structure
> + * @svm_pages: Pointer to the GPU SVM pages structure
Correct. The function's second parameter is `struct drm_gpusvm_pages *svm_pages`, so the parameter doc now matches. The `@gpusvm` parameter was already correct and is left unchanged.
No issues found. Straightforward kernel-doc fix that resolves the two warnings listed in the commit message.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-22 20:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-19 21:55 [PATCH v2] drm/gpusvm: correct kernel-doc for drm_gpusvm_pages_valid_unlocked() Randy Dunlap
2026-02-22 20:21 ` Claude review: " Claude Code Review Bot
2026-02-22 20:21 ` Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox