public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/sun4i: fix kernel-doc warnings in sunxi_engine.h
Date: Mon, 23 Feb 2026 06:20:10 +1000	[thread overview]
Message-ID: <review-patch1-20260219215524.468142-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260219215524.468142-1-rdunlap@infradead.org>

Patch Review

No issues found. All four kernel-doc warnings are addressed correctly:

> -	 * @mode_set
> +	 * @mode_set:

Adds the missing colon required by kernel-doc notation for struct member descriptions.

> + * @list:	engine list management

Promotes the existing inline comment `/* Engine list management */` to a proper kernel-doc `@list` member description in the struct's doc block, and removes the now-redundant inline comment:

> -	/* Engine list management */
>  	struct list_head		list;

This is the right approach — the description is moved up into the kernel-doc block where tooling expects it.

> + * Returns: The array of struct drm_plane backing the layers, or an
> + *		error pointer on failure.

The `Returns:` description for `sunxi_engine_layers_init()` is accurate — the function returns either the result of `ops->layers_init()` or `ERR_PTR(-ENOSYS)`, which matches "an error pointer on failure."

Clean patch, no concerns.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-02-22 20:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 21:55 [PATCH v2] drm/sun4i: fix kernel-doc warnings in sunxi_engine.h Randy Dunlap
2026-02-22 20:20 ` Claude review: " Claude Code Review Bot
2026-02-22 20:20 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260219215524.468142-1-rdunlap@infradead.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox