From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/sun4i: fix kernel-doc warnings in sunxi_engine.h Date: Mon, 23 Feb 2026 06:20:10 +1000 Message-ID: In-Reply-To: <20260219215524.468142-1-rdunlap@infradead.org> References: <20260219215524.468142-1-rdunlap@infradead.org> <20260219215524.468142-1-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review No issues found. All four kernel-doc warnings are addressed correctly: > - * @mode_set > + * @mode_set: Adds the missing colon required by kernel-doc notation for struct member de= scriptions. > + * @list: engine list management Promotes the existing inline comment `/* Engine list management */` to a pr= oper kernel-doc `@list` member description in the struct's doc block, and r= emoves the now-redundant inline comment: > - /* Engine list management */ > struct list_head list; This is the right approach =E2=80=94 the description is moved up into the k= ernel-doc block where tooling expects it. > + * Returns: The array of struct drm_plane backing the layers, or an > + * error pointer on failure. The `Returns:` description for `sunxi_engine_layers_init()` is accurate =E2= =80=94 the function returns either the result of `ops->layers_init()` or `E= RR_PTR(-ENOSYS)`, which matches "an error pointer on failure." Clean patch, no concerns. --- Generated by Claude Code Patch Reviewer