From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: dp: fix kernel-doc warnings in dp.h
Date: Mon, 23 Feb 2026 06:19:10 +1000 [thread overview]
Message-ID: <review-patch1-20260219215535.469520-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260219215535.469520-1-rdunlap@infradead.org>
Patch Review
Four changes, all correct:
**1. Missing `@` prefix on `tps3_supported`:**
> ```
> - * tps3_supported:
> + * @tps3_supported:
> ```
Straightforward fix. All other members in `struct drm_dp_link_caps` already use the `@` prefix; this one was simply missing it.
**2-3. Empty short descriptions for `apply_training` and `configure`:**
> ```
> - * @apply_training:
> + * @apply_training: apply the link training
> ```
> ```
> - * @configure:
> + * @configure: configure the DP link
> ```
kernel-doc warns when a member tag has no description text after the colon. Adding short descriptions resolves the warnings. The descriptions are terse but adequate for self-explanatory callback names.
**4. Moving nested struct member docs to the parent struct's kernel-doc block:**
> ```
> + * @aux_rd_interval.cr: clock recovery read interval
> + * @aux_rd_interval.ce: channel equalization read interval
> ```
> ```
> - /**
> - * @cr: clock recovery read interval
> - * @ce: channel equalization read interval
> - */
> struct {
> unsigned int cr;
> unsigned int ce;
> ```
The old placement used `@cr` and `@ce` as if they were top-level members of `struct drm_dp_link`, which kernel-doc doesn't understand for anonymous nested structs -- it produced an "Excess struct member 'cr'" warning. Moving them to the parent struct's doc block with the `@aux_rd_interval.cr` / `@aux_rd_interval.ce` dotted notation is the correct kernel-doc approach for documenting anonymous nested struct members.
No issues found. The patch is correct and ready to apply.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-02-22 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 21:55 [PATCH RESEND] drm/tegra: dp: fix kernel-doc warnings in dp.h Randy Dunlap
2026-02-22 20:19 ` Claude review: " Claude Code Review Bot
2026-02-22 20:19 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260219215535.469520-1-rdunlap@infradead.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox