From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tegra: dp: fix kernel-doc warnings in dp.h Date: Mon, 23 Feb 2026 06:19:10 +1000 Message-ID: In-Reply-To: <20260219215535.469520-1-rdunlap@infradead.org> References: <20260219215535.469520-1-rdunlap@infradead.org> <20260219215535.469520-1-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Four changes, all correct: **1. Missing `@` prefix on `tps3_supported`:** > ``` > - * tps3_supported: > + * @tps3_supported: > ``` Straightforward fix. All other members in `struct drm_dp_link_caps` already use the `@` prefix; this one was simply missing it. **2-3. Empty short descriptions for `apply_training` and `configure`:** > ``` > - * @apply_training: > + * @apply_training: apply the link training > ``` > ``` > - * @configure: > + * @configure: configure the DP link > ``` kernel-doc warns when a member tag has no description text after the colon. Adding short descriptions resolves the warnings. The descriptions are terse but adequate for self-explanatory callback names. **4. Moving nested struct member docs to the parent struct's kernel-doc block:** > ``` > + * @aux_rd_interval.cr: clock recovery read interval > + * @aux_rd_interval.ce: channel equalization read interval > ``` > ``` > - /** > - * @cr: clock recovery read interval > - * @ce: channel equalization read interval > - */ > struct { > unsigned int cr; > unsigned int ce; > ``` The old placement used `@cr` and `@ce` as if they were top-level members of `struct drm_dp_link`, which kernel-doc doesn't understand for anonymous nested structs -- it produced an "Excess struct member 'cr'" warning. Moving them to the parent struct's doc block with the `@aux_rd_interval.cr` / `@aux_rd_interval.ce` dotted notation is the correct kernel-doc approach for documenting anonymous nested struct members. No issues found. The patch is correct and ready to apply. --- Generated by Claude Code Patch Reviewer