Claude review: drm/vmwgfx: fix kernel-doc warnings in vmwgfx_drv.h

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

The forward declarations were moved from between the kernel-doc comment and the struct definition to above the comment, which is the correct fix. However, the duplicate `struct vmw_bo;` was preserved:

> +struct vmw_bo;
> +struct vmw_bo;
> +struct vmw_resource_dirty;

The original code already had `struct vmw_bo;` twice. Moving them is the right thing to do, but this would have been a good opportunity to drop the duplicate. A duplicate forward declaration is harmless, but it looks like an oversight.

The `vmw_piter_page` return value description was updated to use the `Returns:` tag format, but the text itself is still wrong:

> +/**
>  * vmw_piter_page - Return a pointer to the current page.
>  *
>  * @viter: Pointer to the iterator
>  *
> + * Returns: the DMA address of the page pointed to by @viter.

The function returns a `struct page *`, not a DMA address. The brief description ("Return a pointer to the current page") is correct, but the `Returns:` line was copied from `vmw_piter_dma_addr` above it and was never fixed. Since this patch is specifically about making kernel-doc accurate, it would be worth correcting this to something like "Returns: pointer to the current page."

Everything else in the patch looks correct:
- The `struct vmw-resource` typo fix to `struct vmw_resource` is right.
- The `@mob_node;` to `@mob_node:` semicolon-to-colon fix is right.
- The `@num_regions` to `@num_pages` rename matches the actual struct member name (`unsigned long num_pages`).
- The `@memcpy` to `@do_cpy` rename matches the actual struct member (`void (*do_cpy)(...)`).
- The `@addr` to `@fifo_reg` rename matches the actual parameter name.
- The `/* private: */` markers for `vmw_res_cache_entry.private` and `vmw_dma_map_max` are appropriate.
- All the `/**` to `/*` conversions for section-heading comments are correct — these are not kernel-doc comments and should not use the `/**` prefix.
- The added `@filp`, `@used_prio`, `@dirty`, `@mode`, `@pages`, `@addrs`, `@fmt`, `@vmw`, `@value` descriptions all match actual struct members or function parameters.

---
Generated by Claude Code Patch Reviewer