From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vmwgfx: fix kernel-doc warnings in vmwgfx_drv.h Date: Mon, 23 Feb 2026 06:18:01 +1000 Message-ID: In-Reply-To: <20260219215548.470810-1-rdunlap@infradead.org> References: <20260219215548.470810-1-rdunlap@infradead.org> <20260219215548.470810-1-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The forward declarations were moved from between the kernel-doc comment and= the struct definition to above the comment, which is the correct fix. Howe= ver, the duplicate `struct vmw_bo;` was preserved: > +struct vmw_bo; > +struct vmw_bo; > +struct vmw_resource_dirty; The original code already had `struct vmw_bo;` twice. Moving them is the ri= ght thing to do, but this would have been a good opportunity to drop the du= plicate. A duplicate forward declaration is harmless, but it looks like an = oversight. The `vmw_piter_page` return value description was updated to use the `Retur= ns:` tag format, but the text itself is still wrong: > +/** > * vmw_piter_page - Return a pointer to the current page. > * > * @viter: Pointer to the iterator > * > + * Returns: the DMA address of the page pointed to by @viter. The function returns a `struct page *`, not a DMA address. The brief descri= ption ("Return a pointer to the current page") is correct, but the `Returns= :` line was copied from `vmw_piter_dma_addr` above it and was never fixed. = Since this patch is specifically about making kernel-doc accurate, it would= be worth correcting this to something like "Returns: pointer to the curren= t page." Everything else in the patch looks correct: - The `struct vmw-resource` typo fix to `struct vmw_resource` is right. - The `@mob_node;` to `@mob_node:` semicolon-to-colon fix is right. - The `@num_regions` to `@num_pages` rename matches the actual struct membe= r name (`unsigned long num_pages`). - The `@memcpy` to `@do_cpy` rename matches the actual struct member (`void= (*do_cpy)(...)`). - The `@addr` to `@fifo_reg` rename matches the actual parameter name. - The `/* private: */` markers for `vmw_res_cache_entry.private` and `vmw_d= ma_map_max` are appropriate. - All the `/**` to `/*` conversions for section-heading comments are correc= t =E2=80=94 these are not kernel-doc comments and should not use the `/**` = prefix. - The added `@filp`, `@used_prio`, `@dirty`, `@mode`, `@pages`, `@addrs`, `= @fmt`, `@vmw`, `@value` descriptions all match actual struct members or fun= ction parameters. --- Generated by Claude Code Patch Reviewer