From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Revert "drm/amd/pm: Disable MCLK switching on SI at high pixel clocks"
Date: Mon, 23 Feb 2026 06:01:56 +1000 [thread overview]
Message-ID: <review-patch1-20260221034402.69537-2-rosenp@gmail.com> (raw)
In-Reply-To: <20260221034402.69537-2-rosenp@gmail.com>
Patch Review
The commit message is just:
> This reverts commit d033e8cf4e8f6395102cdbc3cb00dc7cb9542f53.
As Greg KH already pointed out, this needs to explain why the revert is needed. Even though this patch is primarily a prerequisite for patch 2 to revert cleanly, the commit message should say so explicitly, along with a brief description of the overall problem (DC-enabled SI GPUs panic because the high-pixelclock code accesses connector structures that aren't valid under the DC codepath in stable kernels).
The code change itself is straightforward -- it removes the `disable_mclk_switching = true;` assignment and its comment from within the `if (high_pixelclock_count)` block:
> - /* Work around flickering lines at the bottom edge
> - * of the screen when using a single 4K 60Hz monitor.
> - */
> - disable_mclk_switching = true;
After this patch, the `disable_mclk_switching` variable still exists and is still used later in the function; it just won't be set to `true` based on high pixel clock count anymore. The remaining high-pixelclock loop and `conn` variable are still used by the SCLK switching logic, so the code compiles cleanly.
No functional issues with the code change itself. However, note that this patch does not fix the reported crash -- the connector access loop still executes, so the panic persists until patch 2 is also applied.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-22 20:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-21 3:44 [PATCH 0/2] 6.12 and below: amdgpu: fix panic with SI and DC Rosen Penev
2026-02-21 3:44 ` [PATCH 1/2] Revert "drm/amd/pm: Disable MCLK switching on SI at high pixel clocks" Rosen Penev
2026-02-21 5:40 ` Greg KH
2026-02-21 5:54 ` Rosen Penev
2026-02-21 6:33 ` Greg KH
2026-02-22 20:01 ` Claude Code Review Bot [this message]
2026-02-21 3:44 ` [PATCH 2/2] Revert "drm/amd/pm: Disable SCLK switching on Oland with high pixel clocks (v3)" Rosen Penev
2026-02-21 5:41 ` Greg KH
2026-02-21 5:52 ` Rosen Penev
2026-02-21 6:33 ` Greg KH
2026-02-21 8:48 ` Rosen Penev
2026-02-22 20:01 ` Claude review: " Claude Code Review Bot
2026-02-21 5:41 ` [PATCH 0/2] 6.12 and below: amdgpu: fix panic with SI and DC Greg KH
2026-02-21 5:55 ` Rosen Penev
2026-02-22 20:01 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260221034402.69537-2-rosenp@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox