From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Revert "drm/amd/pm: Disable MCLK switching on SI at high pixel clocks" Date: Mon, 23 Feb 2026 06:01:56 +1000 Message-ID: In-Reply-To: <20260221034402.69537-2-rosenp@gmail.com> References: <20260221034402.69537-1-rosenp@gmail.com> <20260221034402.69537-2-rosenp@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The commit message is just: > This reverts commit d033e8cf4e8f6395102cdbc3cb00dc7cb9542f53. As Greg KH already pointed out, this needs to explain why the revert is needed. Even though this patch is primarily a prerequisite for patch 2 to revert cleanly, the commit message should say so explicitly, along with a brief description of the overall problem (DC-enabled SI GPUs panic because the high-pixelclock code accesses connector structures that aren't valid under the DC codepath in stable kernels). The code change itself is straightforward -- it removes the `disable_mclk_switching = true;` assignment and its comment from within the `if (high_pixelclock_count)` block: > - /* Work around flickering lines at the bottom edge > - * of the screen when using a single 4K 60Hz monitor. > - */ > - disable_mclk_switching = true; After this patch, the `disable_mclk_switching` variable still exists and is still used later in the function; it just won't be set to `true` based on high pixel clock count anymore. The remaining high-pixelclock loop and `conn` variable are still used by the SCLK switching logic, so the code compiles cleanly. No functional issues with the code change itself. However, note that this patch does not fix the reported crash -- the connector access loop still executes, so the panic persists until patch 2 is also applied. --- Generated by Claude Code Patch Reviewer