From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dpu: Don't use %pK through printk (again)
Date: Tue, 24 Feb 2026 10:32:44 +1000 [thread overview]
Message-ID: <review-patch1-20260223-restricted-pointers-msm-v1-1-14c0b451e372@linutronix.de> (raw)
In-Reply-To: <20260223-restricted-pointers-msm-v1-1-14c0b451e372@linutronix.de>
Patch Review
> - DRM_ERROR("invalid ctx %pK gc base\n", ctx);
> + DRM_ERROR("invalid ctx %p gc base\n", ctx);
Straightforward `%pK` to `%p` conversion. No issues.
The commit message is well-written: it explains the rationale (why `%pK` is problematic), references the original cleanup commit (1ba9fbe40337) and the commit that reintroduced the usage (39a750ff5fc9). Dmitry's review reply also suggests adding a `Fixes:` tag for the latter commit, which would be a good addition for backporting purposes.
One minor note: the error message itself (`"invalid ctx %p gc base"`) is somewhat confusing -- it's the `gc.base` field that is invalid (zero), not `ctx` itself. But that's pre-existing text not introduced by this patch, so not relevant to this review.
No issues found in this patch.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-02-24 0:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 7:16 [PATCH] drm/msm/dpu: Don't use %pK through printk (again) Thomas Weißschuh
2026-02-23 23:31 ` Dmitry Baryshkov
2026-02-24 0:32 ` Claude review: " Claude Code Review Bot
2026-02-24 0:32 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260223-restricted-pointers-msm-v1-1-14c0b451e372@linutronix.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox