From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Fix incorrect log message in LTTPR mode selection
Date: Tue, 24 Feb 2026 10:28:01 +1000 [thread overview]
Message-ID: <review-patch1-20260223025156.27490-1-hayden.heins@gmail.com> (raw)
In-Reply-To: <20260223025156.27490-1-hayden.heins@gmail.com>
Patch Review
The bug is real: when `vbios_lttpr_aware` is true but `vbios_lttpr_force_non_transparent` is false, the code returns `LTTPR_MODE_TRANSPARENT` but the old log message said `LTTPR_MODE_NON_TRANSPARENT`. The fix correctly changes the log to match the return value.
> - DC_LOG_DC("chose LTTPR_MODE_NON_TRANSPARENT by default due to VBIOS not set DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE set to 1.\n");
> + DC_LOG_DC("chose LTTPR_MODE_TRANSPARENT by default due to VBIOS not set "
> + "DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE set to 1.\n");
> return LTTPR_MODE_TRANSPARENT;
The log text fix is correct. The string split across two lines is fine — the compiler concatenates adjacent string literals.
One minor note: the commit message has a typo — "This upgades the log message" should be "This updates the log message". Also, "upgades" aside, the phrasing is a bit unusual; something like "Fix the log message to match" would be more standard. This doesn't affect the code itself but is worth fixing before applying if the maintainer cares.
No other issues found. The patch is correct and ready to apply (modulo the commit message typo).
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-02-24 0:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 2:51 [PATCH] drm/amd/display: Fix incorrect log message in LTTPR mode selection Hayden Heins
2026-02-24 0:28 ` Claude review: " Claude Code Review Bot
2026-02-24 0:28 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260223025156.27490-1-hayden.heins@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox