From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Fix incorrect log message in LTTPR mode selection Date: Tue, 24 Feb 2026 10:28:01 +1000 Message-ID: In-Reply-To: <20260223025156.27490-1-hayden.heins@gmail.com> References: <20260223025156.27490-1-hayden.heins@gmail.com> <20260223025156.27490-1-hayden.heins@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The bug is real: when `vbios_lttpr_aware` is true but `vbios_lttpr_force_no= n_transparent` is false, the code returns `LTTPR_MODE_TRANSPARENT` but the = old log message said `LTTPR_MODE_NON_TRANSPARENT`. The fix correctly change= s the log to match the return value. > - DC_LOG_DC("chose LTTPR_MODE_NON_TRANSPARENT by default due to VBIOS n= ot set DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE set to 1.\n"); > + DC_LOG_DC("chose LTTPR_MODE_TRANSPARENT by default due to VBIOS not s= et " > + "DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE set to 1.\n"); > return LTTPR_MODE_TRANSPARENT; The log text fix is correct. The string split across two lines is fine =E2= =80=94 the compiler concatenates adjacent string literals. One minor note: the commit message has a typo =E2=80=94 "This upgades the l= og message" should be "This updates the log message". Also, "upgades" aside= , the phrasing is a bit unusual; something like "Fix the log message to mat= ch" would be more standard. This doesn't affect the code itself but is wort= h fixing before applying if the maintainer cares. No other issues found. The patch is correct and ready to apply (modulo the = commit message typo). --- Generated by Claude Code Patch Reviewer