From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: panel: document Atrix 4G and Droid X2 DSI panel Date: Tue, 24 Feb 2026 10:38:13 +1000 Message-ID: In-Reply-To: <20260223064630.12720-2-clamor95@gmail.com> References: <20260223064630.12720-1-clamor95@gmail.com> <20260223064630.12720-2-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The binding looks straightforward. A few observations: > +properties: > + compatible: > + items: > + - const: motorola,mot-panel Using `items` with a single `const` works but could be simplified to just `const: motorola,mot-panel`. Either form is valid. > + vdd-supply: > + description: Regulator for main power supply. > + > + vddio-supply: > + description: Regulator for 1.8V IO power supply. > + > + backlight: true > + reset-gpios: true > + port: true > + > +required: > + - compatible The `reg` property is not in `required`. For a DSI panel, `reg` specifies the virtual channel and is typically needed. The example does include it, so this is just a schema completeness question -- DT binding maintainers may or may not care since the DSI bus binding may enforce it separately. No other issues found with this patch. --- Generated by Claude Code Patch Reviewer