public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: tegra: document Tegra20 HDMI port
Date: Tue, 24 Feb 2026 10:34:48 +1000	[thread overview]
Message-ID: <review-patch1-20260223065500.13357-2-clamor95@gmail.com> (raw)
In-Reply-To: <20260223065500.13357-2-clamor95@gmail.com>

Patch Review

The binding change adds a `port` property and restructures the required properties to allow either the legacy approach or the OF graph approach.

> +  port:
> +    description: HDMI output port for connection to HDMI connector or bridge
> +    $ref: /schemas/graph.yaml#/properties/port

This is a clean addition. The reference to the graph port schema is correct, and since the existing binding has `additionalProperties: false`, the property must be listed here to be allowed.

> -  - nvidia,ddc-i2c-bus
> -  - nvidia,hpd-gpio
> +
> +anyOf:
> +  - required:
> +      - nvidia,ddc-i2c-bus
> +      - nvidia,hpd-gpio
> +  - required:
> +      - port

The `anyOf` logic is correct: at least one of the two groups must be satisfied. This preserves backward compatibility with existing DTS files that use the legacy properties. One thing to note is that `anyOf` also permits a node to have all three properties simultaneously (`nvidia,ddc-i2c-bus`, `nvidia,hpd-gpio`, and `port`). That may or may not be intentional -- if the driver doesn't handle having both the legacy properties and a port simultaneously, it might be worth considering `oneOf` instead. But this is a design choice rather than a bug, and having both present wouldn't violate the schema.

The commit message is accurate but brief. No other issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-24  0:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23  6:54 [PATCH v2 0/2] ARM: tegra: document Tegra20 HDMI port Svyatoslav Ryhel
2026-02-23  6:54 ` [PATCH v2 1/2] dt-bindings: display: " Svyatoslav Ryhel
2026-02-24  0:34   ` Claude Code Review Bot [this message]
2026-02-23  6:55 ` [PATCH v2 2/2] ARM: tegra: transformers: add connector node Svyatoslav Ryhel
2026-02-24  0:34   ` Claude review: " Claude Code Review Bot
2026-02-24  0:34 ` Claude review: ARM: tegra: document Tegra20 HDMI port Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-02-10  9:49 [PATCH v1 0/2] " Svyatoslav Ryhel
2026-02-10  9:49 ` [PATCH v1 1/2] dt-bindings: display: " Svyatoslav Ryhel
2026-02-11  6:27   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260223065500.13357-2-clamor95@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox