From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: tegra: document Tegra20 HDMI port Date: Tue, 24 Feb 2026 10:34:48 +1000 Message-ID: In-Reply-To: <20260223065500.13357-2-clamor95@gmail.com> References: <20260223065500.13357-1-clamor95@gmail.com> <20260223065500.13357-2-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The binding change adds a `port` property and restructures the required properties to allow either the legacy approach or the OF graph approach. > + port: > + description: HDMI output port for connection to HDMI connector or bridge > + $ref: /schemas/graph.yaml#/properties/port This is a clean addition. The reference to the graph port schema is correct, and since the existing binding has `additionalProperties: false`, the property must be listed here to be allowed. > - - nvidia,ddc-i2c-bus > - - nvidia,hpd-gpio > + > +anyOf: > + - required: > + - nvidia,ddc-i2c-bus > + - nvidia,hpd-gpio > + - required: > + - port The `anyOf` logic is correct: at least one of the two groups must be satisfied. This preserves backward compatibility with existing DTS files that use the legacy properties. One thing to note is that `anyOf` also permits a node to have all three properties simultaneously (`nvidia,ddc-i2c-bus`, `nvidia,hpd-gpio`, and `port`). That may or may not be intentional -- if the driver doesn't handle having both the legacy properties and a port simultaneously, it might be worth considering `oneOf` instead. But this is a design choice rather than a bug, and having both present wouldn't violate the schema. The commit message is accurate but brief. No other issues. --- Generated by Claude Code Patch Reviewer