public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/mediatek: dsi: Store driver data before invoking mipi_dsi_host_register
Date: Tue, 24 Feb 2026 10:09:17 +1000	[thread overview]
Message-ID: <review-patch1-20260223141638.2022490-1-l.scorcia@gmail.com> (raw)
In-Reply-To: <20260223141638.2022490-1-l.scorcia@gmail.com>

Patch Review

The fix moves `platform_set_drvdata(pdev, dsi)` from after the IRQ request and waitqueue initialization to just before `mipi_dsi_host_register()`:

> +	platform_set_drvdata(pdev, dsi);
> +
>  	ret = mipi_dsi_host_register(&dsi->host);
>  	if (ret < 0)
>  		return dev_err_probe(dev, ret, "Failed to register DSI host\n");

This is correct. The call chain `mipi_dsi_host_register` -> `mtk_dsi_host_attach` -> `component_add` -> `mtk_dsi_bind` uses `dev_get_drvdata(dev)` to retrieve the `mtk_dsi` struct, so the drvdata must be set before registration.

The `dsi` pointer at this point in `mtk_dsi_probe` has already been allocated (via `devm_drm_bridge_alloc`), driver data matched, clocks obtained, registers mapped, PHY acquired, and the IRQ number retrieved — all the fields that `mtk_dsi_bind` might need are initialized. The `host.ops` and `host.dev` assignments are also already done on the lines immediately above.

If `mipi_dsi_host_register()` fails after drvdata is set, the drvdata will point to the `dsi` struct which is devres-managed and will be freed as part of device cleanup — this is harmless since the device itself won't proceed to use the stale drvdata after a failed probe.

No issues found. The fix is minimal, correct, and well-documented.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-02-24  0:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 14:16 [PATCH v2] drm/mediatek: dsi: Store driver data before invoking mipi_dsi_host_register Luca Leonardo Scorcia
2026-02-24  0:09 ` Claude review: " Claude Code Review Bot
2026-02-24  0:09 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-02-25  9:38 [PATCH v3] " Luca Leonardo Scorcia
2026-02-27  3:42 ` Claude review: " Claude Code Review Bot
2026-02-27  3:42 ` Claude Code Review Bot
2026-03-20 15:37 [PATCH v3 RESEND] " Luca Leonardo Scorcia
2026-03-21 17:36 ` Claude review: " Claude Code Review Bot
2026-03-21 17:36 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260223141638.2022490-1-l.scorcia@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox