From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tiny: ili9486: use DRM_MODE_INIT for proper vrefresh
Date: Tue, 24 Feb 2026 10:01:43 +1000 [thread overview]
Message-ID: <review-patch1-20260223171247.503277-1-mail@singulared.space> (raw)
In-Reply-To: <20260223171247.503277-1-mail@singulared.space>
Patch Review
> - DRM_SIMPLE_MODE(480, 320, 73, 49),
> + DRM_MODE_INIT(30, 480, 320, 73, 49),
The change is correct. Both macros expand through `__DRM_MODE_INIT`, which sets `htotal == hdisplay` and `vtotal == vdisplay` (no blanking intervals), appropriate for an SPI-driven panel with no real sync timing. The only difference is the `.clock` field:
- `DRM_SIMPLE_MODE`: clock = 1 kHz → vrefresh = 1000 / (480 × 320) ≈ 0.006 Hz
- `DRM_MODE_INIT(30, ...)`: clock = 480 × 320 × 30 / 1000 = 4608 kHz → vrefresh = 30 Hz
The multiplication `480 * 320 * 30 = 4,608,000` fits comfortably in an `int` with no overflow risk. The 30 Hz target is reasonable for an SPI display — the actual frame rate will still be limited by bus throughput as noted in the commit message.
The physical dimensions (73 mm × 49 mm) are unchanged, and `DRM_MODE_INIT` is already used in-tree by `appletbdrm.c`, so this is an established pattern.
No issues found. The patch is a clean, minimal fix with a thorough commit message.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-02-24 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 17:12 [PATCH] drm/tiny: ili9486: use DRM_MODE_INIT for proper vrefresh Belousov Maksim
2026-02-24 0:01 ` Claude review: " Claude Code Review Bot
2026-02-24 0:01 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260223171247.503277-1-mail@singulared.space \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox