From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tiny: ili9486: use DRM_MODE_INIT for proper vrefresh Date: Tue, 24 Feb 2026 10:01:43 +1000 Message-ID: In-Reply-To: <20260223171247.503277-1-mail@singulared.space> References: <20260223171247.503277-1-mail@singulared.space> <20260223171247.503277-1-mail@singulared.space> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review > - DRM_SIMPLE_MODE(480, 320, 73, 49), > + DRM_MODE_INIT(30, 480, 320, 73, 49), The change is correct. Both macros expand through `__DRM_MODE_INIT`, which = sets `htotal =3D=3D hdisplay` and `vtotal =3D=3D vdisplay` (no blanking int= ervals), appropriate for an SPI-driven panel with no real sync timing. The = only difference is the `.clock` field: - `DRM_SIMPLE_MODE`: clock =3D 1 kHz =E2=86=92 vrefresh =3D 1000 / (480 =C3= =97 320) =E2=89=88 0.006 Hz - `DRM_MODE_INIT(30, ...)`: clock =3D 480 =C3=97 320 =C3=97 30 / 1000 =3D 4= 608 kHz =E2=86=92 vrefresh =3D 30 Hz The multiplication `480 * 320 * 30 =3D 4,608,000` fits comfortably in an `i= nt` with no overflow risk. The 30 Hz target is reasonable for an SPI displa= y =E2=80=94 the actual frame rate will still be limited by bus throughput a= s noted in the commit message. The physical dimensions (73 mm =C3=97 49 mm) are unchanged, and `DRM_MODE_I= NIT` is already used in-tree by `appletbdrm.c`, so this is an established p= attern. No issues found. The patch is a clean, minimal fix with a thorough commit m= essage. --- Generated by Claude Code Patch Reviewer