From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/xe_pagefault: Disallow writes to read-only VMAs
Date: Tue, 24 Feb 2026 10:00:00 +1000
Message-ID: <review-patch1-20260223172120.98961-7-jonathan.cavitt@intel.com>
In-Reply-To: <20260223172120.98961-7-jonathan.cavitt@intel.com>
References: <20260223172120.98961-6-jonathan.cavitt@intel.com> <20260223172120.98961-7-jonathan.cavitt@intel.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

This is a straightforward bugfix. The check is placed correctly after the VMA lookup:

> +	if (xe_vma_read_only(vma) &&
> +	    pf->consumer.access_type != XE_PAGEFAULT_ACCESS_TYPE_READ) {
> +		err = -EPERM;
> +		goto unlock_vm;
> +	}

This correctly rejects both write and atomic access to read-only VMAs. The `goto unlock_vm` follows the established error path in `xe_pagefault_service`. The `Fixes:` tag is appropriate. No issues found.

---
Generated by Claude Code Patch Reviewer