From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: Use vertical style for imports Date: Tue, 24 Feb 2026 09:40:14 +1000 Message-ID: In-Reply-To: <20260223203833.207955-1-deborah.brouwer@collabora.com> References: <20260223203833.207955-1-deborah.brouwer@collabora.com> <20260223203833.207955-1-deborah.brouwer@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review I compared the old flat imports against the new grouped imports in each of = the five files and confirmed they are equivalent =E2=80=94 every symbol imp= orted before is still imported after, with no additions or omissions. The trailing `//` comments on last items within brace groups (e.g., `Mutex,= //`) follow the kernel Rust convention to force `rustfmt` to preserve the = vertical layout. This is the expected pattern. > ``` > +use kernel::{ > + bits::bit_u32, > + device::{ > + Bound, > + Device, // > + }, > + devres::Devres, > + io::Io, > + prelude::*, // > +}; > ``` The v2 changelog says "Add import io::Io import in regs.rs to resolve confl= ict with v6.19." Looking at the diff, `io::Io` was already present in the o= ld flat imports for `regs.rs`, so this change just refers to ensuring it wa= sn't accidentally dropped during the v1 conversion =E2=80=94 the v2 result = correctly includes it. In `gem.rs`, the old code had `crate::` imports before `kernel::` imports, = which didn't follow the conventional ordering. The new version places `kern= el::` before `crate::`, which is an improvement beyond just the grouping st= yle. No issues found. This is a clean, mechanical style change with no functiona= l impact. --- Generated by Claude Code Patch Reviewer